feat(linter): implement noUnknownTypeSelector rule
#2871
+768
−64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-Project
Kazuhiro-Mimaki
changed the title
Kazuhiro-Mimaki
force-pushed
the
Kazuhiro-Mimaki/selector-type-no-unknown
branch
from
e64097d
to
1ab268f
Compare
CodSpeed Performance ReportMerging #2871 will improve performances by 6.73%Comparing Summary
Benchmarks breakdown
|
togami2864
reviewed
May 16, 2024
crates/biome_css_analyze/src/lint/nursery/no_unknown_type_selector.rs
Outdated
Show resolved
Hide resolved
crates/biome_css_analyze/src/lint/nursery/no_unknown_type_selector.rs
Outdated
Show resolved
Hide resolved
Mouvedia
reviewed
May 16, 2024
|
Hey @Kazuhiro-Mimaki, are you still interested in this PR? |
|
I'm sorry but I forgot this issue... 🙇♂️ |
Kazuhiro-Mimaki
force-pushed
the
Kazuhiro-Mimaki/selector-type-no-unknown
branch
from
3301c6f
to
3ee3123
Compare
Mouvedia
reviewed
Jun 12, 2024
togami2864
reviewed
Jun 17, 2024
crates/biome_css_analyze/src/lint/nursery/no_unknown_type_selector.rs
Outdated
Show resolved
Hide resolved
Kazuhiro-Mimaki
force-pushed
the
Kazuhiro-Mimaki/selector-type-no-unknown
branch
from
aaac721
to
4deab92
Compare
Mouvedia
reviewed
Jun 24, 2024
Mouvedia
reviewed
Jun 24, 2024
Kazuhiro-Mimaki
force-pushed
the
Kazuhiro-Mimaki/selector-type-no-unknown
branch
from
bb39f0a
to
2cafdb8
Compare
Mouvedia
suggested changes
Jun 26, 2024
There was a problem hiding this comment.
dialog is missing
ref https://developer.mozilla.org/en-US/docs/Web/HTML/Element/dialog
Mouvedia
reviewed
Jun 26, 2024
Kazuhiro-Mimaki
force-pushed
the
Kazuhiro-Mimaki/selector-type-no-unknown
branch
from
2cafdb8
to
6bdea8b
Compare
Mouvedia
reviewed
Jul 4, 2024
|
Hi @Kazuhiro-Mimaki, I rebased your PR. Would you mind addressing the latest comments so we can merge them? |
Conaclos
changed the title
ematipico
changed the title
noUnknownTypeSelector rule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2543
Summary
implements selector-type-no-unknown
Test Plan
Add snapshots.